-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated all python files to use pep-3110 exception syntax for python3 compatibility #587
Conversation
38da086
to
b01676b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! (and thanks for the "short, contained" PRs :)
@heartsucker needs a rebase I guess ... |
Also circleci needs a kick (hung/non-responsive job?) |
b01676b
to
b64d660
Compare
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 86.12% 86.15% +0.02%
==========================================
Files 159 159
Lines 28666 28666
Branches 4080 4080
==========================================
+ Hits 24689 24696 +7
+ Misses 3273 3268 -5
+ Partials 704 702 -2
Continue to review full report at Codecov.
|
a91bba9
to
c5a8469
Compare
Hey @meejah I think this one can be merged since that codecov failure seems to be errant. |
10c6d13
to
4a1504b
Compare
4a1504b
to
0750dba
Compare
Hmmm, I wish github could tell me "what changed since I reviewed it last". Oh well :( Also, @heartsucker would it be possible for you to idle in |
Fixes: https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3013
This change is